Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timestamp shall return as iso format #170

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

No description provided.

Copy link
Contributor

@gusin13 gusin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious aren't we returning the btc start timestamp as int64 epoch which is for phase 1 inception time.
how come that is interpreted by fe and not bbn_inception 🤔

@jrwbabylonlab
Copy link
Collaborator Author

curious aren't we returning the btc start timestamp as int64 epoch which is for phase 1 inception time. how come that is interpreted by fe and not bbn_inception 🤔

The phase-1 endpoint is returning as iso format timestamp, not epoch time tho @gusin13

@jrwbabylonlab jrwbabylonlab merged commit b6a296b into main Dec 5, 2024
11 checks passed
@jrwbabylonlab jrwbabylonlab deleted the fix-timestamp-in-iso-format branch December 5, 2024 05:54
@gusin13
Copy link
Contributor

gusin13 commented Dec 5, 2024

ah i see my bad, i just saw the db storing epoch and didn't check the api was formatting it before returning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants